Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ldap error swallowed #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: ldap error swallowed #14

wants to merge 1 commit into from

Conversation

ezioruan
Copy link

This fix will return the origin LDAP error which is fully formated at go-ldap.

@korylprince
Copy link
Owner

Unfortunately, this change would cause a breaking change in the API. Specifically, supplying incorrect credentials to Bind should not return an error. I will leave this PR open as a possible change for a v4 of the API, but don't find this alone compelling enough to release a new API version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ezioruan @korylprince