Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.0 #51

Closed
20 tasks done
korzio opened this issue Sep 22, 2017 · 4 comments
Closed
20 tasks done

Release 1.2.0 #51

korzio opened this issue Sep 22, 2017 · 4 comments
Milestone

Comments

@korzio
Copy link
Owner

korzio commented Sep 22, 2017

  • Create a release ticket in github. Copy this checklist.
  • Remove TODOs
  • Make a release branch
  • Document new state algorithm
  • Add const docs
  • Update Readme (supports draft-06)
  • Add docs to npm ignore
VERSION="..."
VERSIONALPHA="$VERSION-alpha.0"
ISSUE="..."

git checkout -b release/$VERSION
  • Update package.json version to $VERSIONALPHA and commit
git commit -m "release: Update package version to $VERSIONALPHA #ISSUE"
  • Tag with the alpha version
git tag $VERSIONALPHA
  • Publish test npm version $VERSIONALPHA
npm publish
  • Check package internals - contains all required files (lib/, README.md, ./djv.js, package.json, ...), no extra files
  • Check with updated json-schema test suite - check generated report
  • Check speed metrics
  • Update package.json version to $VERSION and commit
git commit -m "release: Update package version to $VERSION #ISSUE"
  • Create a changelog
npm run changelog
  • Tag $VERSION
git tag $VERSION
  • Merge release branch to master (via github)
  • Publish version $VERSION
npm publish
  • Send update to gitter
  • Update json-schema supports draft-06 description
@korzio korzio added this to the 1.2.0 milestone Sep 22, 2017
This was referenced Sep 22, 2017
korzio added a commit that referenced this issue Sep 22, 2017
…te resolution id algorithm to not use multiple functions calls #51
korzio added a commit that referenced this issue Sep 22, 2017
@korzio
Copy link
Owner Author

korzio commented Sep 25, 2017

Performance

Before

performance

Validator Relative speed Number of test runs per second
djv 100% 24087 (± 2.15%)

After

performance

Validator Relative speed Number of test runs per second
djv 100% 23386 (± 2.38%)

@korzio
Copy link
Owner Author

korzio commented Sep 25, 2017

Validation Errors

Before

All validators fail this test

some languages do not distinguish between different types of numeric value, a float is not an integer even without fractional part

failed tests

Some validators have deliberately chosen not to support parts of the spec. Go to the djv homepage to learn if
that is the case for these tests.

test failed reason
ECMA 262 regex non-compliance, ECMA 262 has no support for \Z anchor from .NET Expected result: false but validator returned: true
validation of URIs, an invalid protocol-relative URI Reference Expected result: false but validator returned: true
ref overrides any sibling keywords, ref valid, maxItems ignored Expected result: true but validator returned: false
base URI change - change folder in subschema, number is valid Expected result: true but validator returned: false
root ref in remote ref, string is valid Expected result: true but validator returned: "Maximum call stack size exceeded"
root ref in remote ref, object is invalid Expected result: false but validator returned: "Maximum call stack size exceeded"

All other tests passed.

After

All validators fail this test

some languages do not distinguish between different types of numeric value, a float is not an integer even without fractional part

All other tests passed.

@korzio
Copy link
Owner Author

korzio commented Sep 27, 2017

@korzio
Copy link
Owner Author

korzio commented Sep 27, 2017

@korzio korzio closed this as completed Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant