add minmea_getdate() #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
added a commit
to benpicco/RIOT
that referenced
this pull request
Feb 13, 2020
Add a fucntion to expose the internal `struct tm` that is populated
with the GPS date.
This allows for easy syncing the RTC with the GPS time without having
to convert back and forth between `struct tm` and `time_t`.
struct tm now;
minmea_getdate(&now, data, time);
rtc_set_time(&now)
upstream PR: kosma/minmea#45
|
Needs tests before we can merge. |
cmorganBE
requested changes
May 20, 2022
The GPS date is internally converted to a struct tm anyway. Add a function to make use of this for external users too.
|
Merged. Thanks for this contribution, it does indeed make sense and should have been in the library from the beginning! Changes I did to the original PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed a
struct tminstead of a Unix timestamp.The struct is already being assembled in
minmea_gettime()and convertingstruct tm->time_t->struct tmis silly, so I added a function to make that functionality available for external users.