Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in ie11 #53

Closed
magicspon opened this issue Aug 26, 2016 · 2 comments
Closed

Doesn't work in ie11 #53

magicspon opened this issue Aug 26, 2016 · 2 comments

Comments

@magicspon
Copy link

magicspon commented Aug 26, 2016

Hello,

I'm having issues getting this to work with IE11. The demo site is also not working in ie11. Pressing play on the examples doesn't do anything.

The error is in the _jsonp function

script.src = _appendQueryParam(url, 'callback', id);

IE throws error saying 'invalid property type'

Any thoughts?

@magicspon
Copy link
Author

magicspon commented Aug 29, 2016

Can anyone shed any light on this?

I've made a copy of soundcloud-audio and changed the jsonp function to use a promise based one (fetch-jsonp) and I'm getting pretty much the same error.

Error: Invalid property value.
   {
      [functions]: ,
      __proto__: {
         [functions]: ,
         __proto__: {
            [functions]: ,
            __proto__: null
         },
         message: "",
         name: "Error"
      },
      description: "Invalid property value.",
      message: "Invalid property value.",
      name: "Error",
      number: -2146827908,
      stack: "Error: Invalid property value.
   at SoundCloud.prototype.play (http://192.168.1.112:3000/_assets/js/dist/app.js:95:9)
   at clickHandle (http://192.168.1.112:3000/_assets/js/dist/app.js:189:13)"
   }

I've also noticed that a few other soundcloud react components aren't working in ie11. Wondering if something on the soundcloud side of things is borked.

waaaaa! :(

@superhighfives
Copy link

Ran into the same problem on https://koya.brailleface.co, but it looks like it's an issue with the https://github.com/voronianski/soundcloud-audio.js/ package.

I've rolled back to soundcloud-audio 0.1.7 and it's working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants