Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds list on commit details page loads slowly #52

Closed
kostmo opened this issue Sep 2, 2019 · 1 comment
Closed

Builds list on commit details page loads slowly #52

kostmo opened this issue Sep 2, 2019 · 1 comment
Labels
performance Speed improvements

Comments

@kostmo
Copy link
Owner

kostmo commented Sep 2, 2019

Example commit details page:
https://dr.pytorch.org/commit-details.html?sha1=f3f372edc0981e2a85c18df0ae91bd4f60dfff44

This page uses the same underlying VIEW, "best_pattern_match_augmented_builds", as the build details page (see issue #49).

However, for reasons not yet discovered, the same query optimization method does not work between both uses of the view (querying by commit vs querying by build number).

@kostmo kostmo added the performance Speed improvements label Sep 2, 2019
@kostmo kostmo changed the title Commit details page loading is slow Builds list on commit details page loads slowly Sep 2, 2019
@kostmo kostmo closed this as completed in b57d574 Sep 2, 2019
@kostmo
Copy link
Owner Author

kostmo commented Sep 2, 2019

The following API endpoint now has improved performance:
https://dr.pytorch.org/api/commit-builds?sha1=f3f372edc0981e2a85c18df0ae91bd4f60dfff44

Version Time
Original 17.8 sec
After best_pattern_match_augmented_builds view simplification (397efa1) 8.5 sec
After manual predicate pushing (b57d574) 1.9 sec

cc @ezyang, @dskhudia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Speed improvements
Projects
None yet
Development

No branches or pull requests

1 participant