Use Unmarshal for Go #234
Merged
Use Unmarshal for Go #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original: Memory: <411MB Time: 1.95s New Code: Memory: 215MB Time: 1.7s
|
Looks good, but could you please apply gofmt as looks like there are inconsistent indentation in the changed code. |
|
@nuald Thanks, formatted. |
Closed
nuald
added a commit
to nuald/benchmarks
that referenced
this pull request
Feb 10, 2020
nuald
added a commit
that referenced
this pull request
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the conversion to string part, it can read json file into struct, result in less code.
Original:
Memory: <411MB
Time: 1.95s
New Code:
Memory: 215MB
Time: 1.7s