Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kostya-sigar build failure #2

Closed
zcater opened this issue Jun 9, 2018 · 13 comments
Closed

kostya-sigar build failure #2

zcater opened this issue Jun 9, 2018 · 13 comments

Comments

@zcater
Copy link

zcater commented Jun 9, 2018

Hello.
I come here from trying to update diaspora. I have little to no knowledge with ruby stuff so please excuse any wrong assumptions.

I tried both 2.0.0 and 2.0.2 and the build fails.

Here are the build logs: 2.0.0 and 2.0.2

@kostya
Copy link
Owner

kostya commented Jun 9, 2018

hm, what is your os, ruby version, i just ok install it on ruby 2.3.1.
gem install sigar also failed?

@zcater
Copy link
Author

zcater commented Jun 9, 2018

Sorry, I should've posted these from the beginning.

I'm on Gentoo with glibc-2.26, gcc-6.4.0, ruby-2.3.7.

@zcater
Copy link
Author

zcater commented Jun 9, 2018

Trying to build sigar seems to have the same issues.

Build log for gem install sigar

@kostya
Copy link
Owner

kostya commented Jun 9, 2018

seems you have no functions major and minor in stdlibs.

i find in my /usr/include/sys/types.h this functions:

static inline __int32_t  major(__uint32_t _x)
{
  return (__int32_t)(((__uint32_t)_x >> 24) & 0xff);
}

static inline __int32_t  minor(__uint32_t _x)
{
  return (__int32_t)((_x) & 0xffffff);
}

can you try git clone this rep, then rake build, then add this functions or from http://unix.superglobalmegacorp.com/Net2/newsrc/sys/types.h.html, to linux_sigar.c and rake build again.

@zcater
Copy link
Author

zcater commented Jun 9, 2018

That file is from glibc.

From a quick google search it seems a common issue with glibc-2.26.

For example in https://jira.mongodb.org/browse/SERVER-29855 they seem to be recommending to also include sys/sysmacros.h.

@kostya
Copy link
Owner

kostya commented Jun 9, 2018

so if you include sys/sysmacros.h in linux_sigar.c, this is fixed?

@zcater
Copy link
Author

zcater commented Jun 9, 2018

This is the build log for rake build of this repo after I added sys/sysmacros.h.

Looks ok-ish to me.

@kostya
Copy link
Owner

kostya commented Jun 9, 2018

i push gem kostya-sigar 2.0.3.test, can you test it. using solutions from this https://wiki.gentoo.org/wiki/Glibc_2.26_porting_notes/sysmacros.h.

@kostya kostya closed this as completed in 5076409 Jun 9, 2018
@zcater
Copy link
Author

zcater commented Jun 9, 2018

Unfortunately it's still not building. The log looks the same with 2.0.3.test.

@kostya
Copy link
Owner

kostya commented Jun 9, 2018

this is strange because i just add this fix https://wiki.gentoo.org/wiki/Glibc_2.26_porting_notes/sysmacros.h

@kostya kostya reopened this Jun 9, 2018
@kostya
Copy link
Owner

kostya commented Jun 9, 2018

5076409

@kostya kostya closed this as completed in a2c6758 Jun 10, 2018
@kostya
Copy link
Owner

kostya commented Jun 10, 2018

i think i fix it in 2.0.4

@zcater
Copy link
Author

zcater commented Jun 10, 2018

It works. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants