Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and add unit tests #22

Merged
merged 3 commits into from
Aug 21, 2021
Merged

Refactoring and add unit tests #22

merged 3 commits into from
Aug 21, 2021

Conversation

kotarot
Copy link
Owner

@kotarot kotarot commented Aug 21, 2021

No description provided.

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #22 (1b46c35) into main (e6caabc) will increase coverage by 6.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   85.76%   92.13%   +6.36%     
==========================================
  Files           8        8              
  Lines         267      267              
==========================================
+ Hits          229      246      +17     
+ Misses         38       21      -17     
Flag Coverage Δ
unittests 92.13% <ø> (+6.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rectangle_packing_solver/sequence_pair.py 81.91% <0.00%> (+1.06%) ⬆️
rectangle_packing_solver/problem.py 100.00% <0.00%> (+21.05%) ⬆️
rectangle_packing_solver/solution.py 100.00% <0.00%> (+40.00%) ⬆️
rectangle_packing_solver/floorplan.py 100.00% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6caabc...1b46c35. Read the comment docs.

@kotarot kotarot force-pushed the add-tests branch 3 times, most recently from 482b0f0 to 2f223e0 Compare August 21, 2021 15:24
@kotarot kotarot merged commit 32a28f1 into main Aug 21, 2021
@kotarot kotarot deleted the add-tests branch August 21, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant