This repository has been archived by the owner on Sep 7, 2022. It is now read-only.
Fix multiple markdown table issues. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) In the case of a second header declared in the body of a table, it will be treated as a regular row with data
2) If the '<thead>' tag is missing, then a '<th>' tag is considered a row, even if it is the first row.
This pr will now ignore the '<tbody>' tag and parse the actual rows individually checking if it is
a header or something else.
Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen
force-pushed
the
markdownHeaderFixFinal
branch
from
6c0c825
to
d61e8de
Compare
|
Looks good, I'll try to merge and release tomorrow but might take more time. |
|
1.2.0 released 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft, I need to go through and fix the formatting issues.
In the case of a second header declared in the body of a table, it will be treated as a regular row with data
If the '' tag is missing, then a '' tag is considered a row, even if it is the first row.
This pr will now ignore the '' tag and parse the actual rows individually checking if it is
a header or something else.