-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix packup to correctly handle melpa-stable, and other fixes #108
Conversation
@@ -10,7 +10,7 @@ | |||
|
|||
(package-initialize) | |||
|
|||
(defvar kotct/packup-marker-char ?x | |||
(defvar kotct/packup-marker-char ?* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept seeing x
as the mark, so my brain would go to mark something and I'd hit x
on my keyboard. Then it would execute the transaction. Changing to *
avoids this issue and also brings the marks more in line with the rest of emacs (think dired, list-buffers, etc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just a couple of English-related nits.
.emacs.d/lisp/package/packup.el
Outdated
Does not automatically refresh package list." | ||
(every (lambda (x) (package-installed-p package (package-desc-version x))) | ||
(cdr (assq package package-archive-contents)))) | ||
"Returns T if PACKAGE is installed and up-to-date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
T
→ t
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it should probably just be "non-nil", since that's what package-installed-p
says in its docstring.
.emacs.d/lisp/package/packup.el
Outdated
(cdr (assq package package-archive-contents)))) | ||
"Returns T if PACKAGE is installed and up-to-date. | ||
Does not automatically refresh package list. | ||
Before emacs 25, we have to manually check in preferred-repository order." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emacs
→ Emacs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
Since this PR does a LOT. I would appreciate it if you could checkout and try some things on the branch. You should be able to delete your |
addressed comments and made some other docstring changes
Okay, I did that. I was able to install everything I needed.
EDIT: For reference, here's the package.el source that corresponds to the U behavior in |
Yeah, we should essentially end up with the same result as using So... did it work on the real branch? |
Yes, I edited my comment a few times to match the current state of my hunt. After nuking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After poking around, I'm happy with using this in production.
I am surprised nuking .elc files had an impact. We should always prefer the newer file between .el and .elc. It could be an issue with how we autoload. Probably requires further investigation in a separate issue. I want to leave this open for at least a couple days in case @samontea has a chance to glance at it (since he wrote a lot of the code that was modified). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
That's right: packup no longer tries to install the latest melpa even though you told it to use melpa-stable! Woo!
Other things I like are added. Feel free to complain if you don't like them.
This resolves #99.