Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to visAccumulate for number of output buffer frames #997

Merged
merged 2 commits into from Oct 13, 2021
Merged

Add check to visAccumulate for number of output buffer frames #997

merged 2 commits into from Oct 13, 2021

Conversation

andrerenard
Copy link
Member

@andrerenard andrerenard commented Sep 23, 2021 •
edited

This change throws a runtime error if the condition in #992 occurs. To summarize that ticket: the system will get into a bad state if the number of frames in the output buffer of visAccumulate is less than num_freq_in_frame for multi-frequency configurations.

Closes #992

aelanman
aelanman approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@aelanman aelanman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- Thanks for fixing this!

@andrerenard andrerenard merged commit 972255f into develop Oct 13, 2021
@andrerenard andrerenard deleted the ar/add_num_frames_check branch October 13, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelanman aelanman aelanman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metadata pointer is NULL in EigenVisIter for multi frequency streems
2 participants
@andrerenard @aelanman