Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Fix missing publish task #10

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

tcrawford-figure
Copy link
Contributor

@tcrawford-figure tcrawford-figure commented Feb 9, 2023

My apologies, I forgot to apply the new publishing convention plugin to the build. This is why we were missing the publish task in the master action. I validated that the task is available from the project root using ./gradlew tasks --all. Everything should be good now for publishing.

@Kantis Kantis merged commit f1aebbd into kotest:master Feb 9, 2023
@Kantis
Copy link
Member

Kantis commented Feb 9, 2023

@tcrawford-figure @jonasg13 Do you think you could give the snapshot a go with Kotest 5.5.5 before a proper release?

@jonasg13
Copy link

@Kantis should we expect to see a new snapshot here: https://oss.sonatype.org/content/repositories/snapshots/io/kotest/extensions/kotest-extensions-embedded-kafka/ ... or did you mean to build it locally and run with kotest 5.5.5?

@Kantis
Copy link
Member

Kantis commented Feb 10, 2023

@Kantis should we expect to see a new snapshot here: https://oss.sonatype.org/content/repositories/snapshots/io/kotest/extensions/kotest-extensions-embedded-kafka/ ... or did you mean to build it locally and run with kotest 5.5.5?

Its here: https://s01.oss.sonatype.org/content/repositories/snapshots/io/kotest/extensions/kotest-extensions-embedded-kafka/

(Badge in readme needs to be updated to the new snapshot url)

@tcrawford-figure
Copy link
Contributor Author

tcrawford-figure commented Feb 10, 2023

@Kantis I just found that actually and talked to @jonasg13 about needing to update the README as well. I can create a PR tomorrow to update the links. We'll test with the snapshot on our side tomorrow as well and let you know how that goes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants