Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arb.bigInt always returns 0 #2013

Closed
NikolayMetchev opened this issue Jan 21, 2021 · 0 comments · Fixed by #2014
Closed

Arb.bigInt always returns 0 #2013

NikolayMetchev opened this issue Jan 21, 2021 · 0 comments · Fixed by #2014
Labels
bug 🐛 Issues that report a problem or error in the code. good-first-issue 👶 Suitable for newcomers looking to contribute to the project. property-testing 📏 Related to the property testing mechanisms within the testing framework.
Milestone
4.4

Comments

@NikolayMetchev
Copy link

Which version of Kotest are you using
4.3.2

The loop on this line isn't changing the bigInt variable.

kotest/kotest-property/src/jvmMain/kotlin/io/kotest/property/arbitrary/bigint.kt

Line 8 in 99138d1

fun Arb.Companion.bigInt(maxNumBits: Int): Arb<BigInteger> {

@LeoColman LeoColman added bug 🐛 Issues that report a problem or error in the code. good-first-issue 👶 Suitable for newcomers looking to contribute to the project. property-testing 📏 Related to the property testing mechanisms within the testing framework. labels Jan 21, 2021
LeoColman added a commit that referenced this issue Jan 22, 2021
@LeoColman
Fix BigIntArb
7663ba6 
Fixes #2013
@LeoColman LeoColman mentioned this issue Jan 22, 2021
Merged
@sksamuel sksamuel added this to the 4.4 milestone Jan 22, 2021
@sksamuel sksamuel mentioned this issue Jan 22, 2021
Closed
43 tasks
LeoColman added a commit that referenced this issue Jan 22, 2021
@LeoColman
Fix BigIntArb (#2014)
45d9e1f 
Fixes #2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Issues that report a problem or error in the code. good-first-issue 👶 Suitable for newcomers looking to contribute to the project. property-testing 📏 Related to the property testing mechanisms within the testing framework.
Projects
None yet
Milestone
4.4
Development

Successfully merging a pull request may close this issue.

Fix BigIntArb kotest/kotest
3 participants
@NikolayMetchev @sksamuel @LeoColman