-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements on Eventually given Until deprecation #2044
Comments
…about predicate failures for #2044
I think we shouldn't have normal predicates, just matchers and a good way for handling them, because then we can leverage their elaborate error message generation. |
By changing to soft assertion mode within the eventually block I think we can catch these more gracefully. |
I'll look at switching to soft, but I think that probably should be up to the tester to opt in to. What if they don't want every assertion to run if one fails? I also think the predicate is fine, consider a producer that returns a kotlin |
Totally easy with matchers: |
@xerus2000 pointed out some issues with my changes made in #2022 and those should be fixed:
EventuallyPredicate
should be atypealias
instead of afun interface
eventually
f
for eventually so you can useeventually
like you could useuntil
(and fix the deprecation replace message)The text was updated successfully, but these errors were encountered: