Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate test name mode #2234

Closed
sksamuel opened this issue May 4, 2021 · 0 comments · Fixed by #2235
Closed

Duplicate test name mode #2234

sksamuel opened this issue May 4, 2021 · 0 comments · Fixed by #2235
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.

Comments

@sksamuel
Copy link
Member

sksamuel commented May 4, 2021

Currently we error when a test has a duplicate name.

However, when using data driven tests, this is not great because if you are using a non-data class, or any class on Javascript, the test names will end up with the same value (the class name).
@sksamuel sksamuel added the enhancement ✨ Suggestions for adding new features or improving existing ones. label May 4, 2021
sksamuel added a commit that referenced this issue May 4, 2021
@sksamuel
Add DuplicateTestNameMode #2234
aaef58a
@sksamuel sksamuel mentioned this issue May 4, 2021
Merged
sksamuel added a commit that referenced this issue May 5, 2021
@sksamuel
Add DuplicateTestNameMode #2234 (#2235)
0d4b396 
* Add DuplicateTestNameMode #2234

* Updated tests

* Updated tests

* Fixed test

* Fixed test

* Fixed test

* Fixed test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add DuplicateTestNameMode #2234 kotest/kotest
1 participant
@sksamuel