Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutable test clock #2655

Closed
Tracked by #2678
sksamuel opened this issue Nov 18, 2021 · 8 comments
Closed
Tracked by #2678

Add mutable test clock #2655

sksamuel opened this issue Nov 18, 2021 · 8 comments
Labels
assertions 🔍 Related to the assertion mechanisms within the testing framework. enhancement ✨ Suggestions for adding new features or improving existing ones. good-first-issue 👶 Suitable for newcomers looking to contribute to the project.
Milestone

Comments

@sksamuel
Copy link
Member

Would be nice if we had a fixed clock but that could be advanced manually.

@sksamuel sksamuel added the enhancement ✨ Suggestions for adding new features or improving existing ones. label Nov 18, 2021
@sksamuel sksamuel added this to the 5.1 milestone Nov 18, 2021
@sksamuel sksamuel added good-first-issue 👶 Suitable for newcomers looking to contribute to the project. assertions 🔍 Related to the assertion mechanisms within the testing framework. labels Nov 18, 2021
@sksamuel sksamuel mentioned this issue Nov 27, 2021
16 tasks
@pientaa
Copy link
Contributor

pientaa commented Dec 6, 2021

I can take that issue, too

@sksamuel
Copy link
Member Author

Great!

@sksamuel
Copy link
Member Author

its the java.time.Clock that we want to implement.

@sksamuel
Copy link
Member Author

@pientaa did you still intend to do this ?

@pientaa
Copy link
Contributor

pientaa commented Jan 13, 2022

@sksamuel yes, I'm sorry, I was busy recently

@sksamuel
Copy link
Member Author

No problem, just wondering :)

@pientaa
Copy link
Contributor

pientaa commented Jan 13, 2022

@sksamuel after looking at java.time.Clock I noticed that there are already implemented such classes: OffsetClock and TickClock. And they seem to be exactly what you asked for. Or maybe there is something that I missed or misunderstood?

@sksamuel
Copy link
Member Author

sksamuel commented Jan 13, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assertions 🔍 Related to the assertion mechanisms within the testing framework. enhancement ✨ Suggestions for adding new features or improving existing ones. good-first-issue 👶 Suitable for newcomers looking to contribute to the project.
Projects
None yet
Development

No branches or pull requests

2 participants