Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags defined in spec being ignored #3056

Closed
sksamuel opened this issue Jun 13, 2022 · 1 comment · Fixed by #3189
Closed

Tags defined in spec being ignored #3056

sksamuel opened this issue Jun 13, 2022 · 1 comment · Fixed by #3189
Assignees
Labels
bug 🐛 Issues that report a problem or error in the code. framework 🏗️ Pertains to the core structure and components of the Kotest framework. pinned 📌 Issues of high importance or that need to remain visible.
Milestone

Comments

@sksamuel
Copy link
Member

internal class AuctionSniperEndToEndContainerTest : StringSpec({

  tags(Docker)

  listener(openfireTestContainer(Paths.get("../docker-openfire")).perSpec())
  ...
}

object Docker : Tag()

object DockerTagExtension : TagExtension {

  override fun tags(): TagExpression =
    if (shouldRunDockerTests()) Empty else exclude(Docker)

  private fun shouldRunDockerTests() = !runningAsPartOfBuild()

  private fun runningAsPartOfBuild() = System.getenv("BUILD_SYSTEM") != null
}

See slack thread https://kotlinlang.slack.com/archives/CT0G9SD7Z/p1640113256328100

@sksamuel sksamuel added bug 🐛 Issues that report a problem or error in the code. framework 🏗️ Pertains to the core structure and components of the Kotest framework. labels Jun 13, 2022
@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale 🏚️ Issues that were lost to time and are no longer up-to-date label Jul 31, 2022
@sksamuel sksamuel added pinned 📌 Issues of high importance or that need to remain visible. and removed stale 🏚️ Issues that were lost to time and are no longer up-to-date labels Jul 31, 2022
@sksamuel sksamuel added this to the 5.5 milestone Aug 29, 2022
@sksamuel sksamuel self-assigned this Aug 29, 2022
@sksamuel sksamuel modified the milestones: 5.5, 5.6 Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issues that report a problem or error in the code. framework 🏗️ Pertains to the core structure and components of the Kotest framework. pinned 📌 Issues of high importance or that need to remain visible.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant