Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags defined in spec should be applied before listeners #3189

Merged
merged 9 commits into from
Mar 23, 2023
Merged

Tags defined in spec should be applied before listeners #3189

merged 9 commits into from
Mar 23, 2023

Conversation

sksamuel
Copy link
Member

Fixes #3056

@sksamuel sksamuel requested a review from a team August 29, 2022 02:48
@LeoColman
Copy link
Member

I don't understand the ref package. Most of changes are related to this refactor hahah

@stale
Copy link

stale bot commented Oct 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale 🏚️ Issues that were lost to time and are no longer up-to-date label Oct 1, 2022
@sksamuel
Copy link
Member Author

sksamuel commented Oct 2, 2022

I don't understand the ref package. Most of changes are related to this refactor hahah

I just moved out the spec ref interceptors from the spec interceptors

@stale stale bot removed the stale 🏚️ Issues that were lost to time and are no longer up-to-date label Oct 2, 2022
@stale
Copy link

stale bot commented Dec 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale 🏚️ Issues that were lost to time and are no longer up-to-date label Dec 21, 2022
@stale stale bot closed this Dec 31, 2022
@Kantis Kantis reopened this Feb 2, 2023
@stale stale bot removed the stale 🏚️ Issues that were lost to time and are no longer up-to-date label Feb 2, 2023
@Kantis
Copy link
Member

Kantis commented Feb 13, 2023

@sksamuel please check if my commit makes sense. It fixes the tests and I think the behaviour makes sense

@stale
Copy link

stale bot commented Mar 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale 🏚️ Issues that were lost to time and are no longer up-to-date label Mar 18, 2023
@Kantis Kantis added this to the 5.6 milestone Mar 21, 2023
@stale stale bot removed the stale 🏚️ Issues that were lost to time and are no longer up-to-date label Mar 21, 2023
@Kantis Kantis enabled auto-merge (squash) March 21, 2023 21:38
@Kantis Kantis merged commit a00fae8 into master Mar 23, 2023
@Kantis Kantis deleted the feature/_056 branch March 23, 2023 21:49
@Kantis Kantis mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kantis Kantis Kantis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.6
Development

Successfully merging this pull request may close these issues.

Tags defined in spec being ignored
3 participants
@sksamuel @LeoColman @Kantis