Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project-level config is not working for iOS target #3804

Closed
OSemenovBoyarka opened this issue Dec 11, 2023 · 4 comments
Closed

Project-level config is not working for iOS target #3804

OSemenovBoyarka opened this issue Dec 11, 2023 · 4 comments
Labels
bug 🐛 Issues that report a problem or error in the code. framework 🏗️ Pertains to the core structure and components of the Kotest framework. multiplatform 🌐 This label is designated for issues and pull requests that concern the Kotest framework's compatibil

Comments

@OSemenovBoyarka
Copy link

OSemenovBoyarka commented Dec 11, 2023

Which version of Kotest are you using
Kotest version is 5.8.0
Kotlin version is 1.9.20
Project is shared Kotlin Multiplatform Mobile library consumed by Android and iOS applications.

The issue
It appears Project-Level Config is not supported on non-JVM targets (I've tested iOS only).
Android target picks up config properly while iOS completely ignores it.

Not sure if that is not implemented yet, but looking to this commit it seems so.

Are there any plans to add support of that feature or at least updating documentation to clearly state that?

@OSemenovBoyarka
Copy link
Author

It appears to work if I change AbstractProjectConfig subclass from object to class

@LeoColman LeoColman added bug 🐛 Issues that report a problem or error in the code. multiplatform 🌐 This label is designated for issues and pull requests that concern the Kotest framework's compatibil framework 🏗️ Pertains to the core structure and components of the Kotest framework. labels Jan 1, 2024
@LeoColman
Copy link
Member

So do you think we should just document it as such @OSemenovBoyarka?
As I understand, you made it work with a simple change to the definition, right?

@OSemenovBoyarka
Copy link
Author

@LeoColman yep, that is true, simple change made that work. I think clearly highlighting it in documentation should fix the problem.

Also documentation lack information of which project config features are working with JVM targets only (ones I've faced - AutoScan and isolationMode are applied to JVM only).

@sksamuel
Copy link
Member

Updated docs to specify class and marked in javadoc which options are jvm only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issues that report a problem or error in the code. framework 🏗️ Pertains to the core structure and components of the Kotest framework. multiplatform 🌐 This label is designated for issues and pull requests that concern the Kotest framework's compatibil
Projects
None yet
Development

No branches or pull requests

3 participants