Around advice in the spec DSL

[sksamuel]

class MyTest : WordSpec() {
  private val manager = ...
  override fun aroundTest(test: () -> TestResult) { 
    manager.transaction.begin()
    test()
    manager.transaction.commit()
  }
}

[sksamuel]

@Kerooker ?

[LeoColman]

Perhaps this can be implemented as an extension?

…

On Wed., May 29, 2019, 17:50 Stephen Samuel, ***@***.***> wrote: @Kerooker <https://github.com/Kerooker> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#794>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMBCI5KWN45JOIQWW4D563PX3UBJANCNFSM4HQVCHFQ> .

[sksamuel]

Yes, we just need to make Spec itself have a aroundTest and aroundSpec method which create an extension and register it. No-op by default. Like we do for the other spec methods which just delegate as a listener.

[LeoColman]

Do we want to add more things to the spec class?

I believe this can be delegated to a listener that has a beforeTest and afterTest, without the need to add another construct. What do you think?

[sksamuel]

Can it?

…

On Wed, 29 May 2019 at 16:37, Leonardo Colman Lopes < ***@***.***> wrote: Do we want to add more things to the spec class? I believe this can be delegated to a listener that has a beforeTest and afterTest, without the need to add another construct. What do you think? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#794>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFVSGUR7XGFHGUAT2OETFDPX3ZQZANCNFSM4HQVCHFQ> .

[LeoColman]

Similar to the constantNow listeners, it runs beforeTest and afterTest, isn't that what we kinda want?

[sksamuel]

Yes, but it's the ability to keep a variable in scope. val a = A() runTest a.stop()

…

On Wed, 29 May 2019 at 16:58, Leonardo Colman Lopes < ***@***.***> wrote: Similar to the constantNow listeners, it runs beforeTest and afterTest, isn't that what we kinda want? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#794>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFVSGTMYP3FJ5LOPQ73WETPX34BLANCNFSM4HQVCHFQ> .

[LeoColman]

I think we can do that with listeners, can't we?

[sksamuel]

Now without creating the variables outside of the before / after scopes.

[sksamuel]

This can be easily done with the new DSL.

[sksamuel]

Question/todo: add extension callbacks to the new DSL like the other callbacks.

[sksamuel]

I had a little play with this:

eg

   aroundTest { runtest ->
      println("Starting test")
      runtest {
         println("After test")
      }
   }

[sksamuel]

Now in master.