Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nested describe blocks in DescribeSpec #902

Closed
lwasyl opened this issue Jul 19, 2019 · 1 comment · Fixed by #905
Closed

Allow nested describe blocks in DescribeSpec #902

lwasyl opened this issue Jul 19, 2019 · 1 comment · Fixed by #905
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.

Comments

@lwasyl
Copy link
Contributor

lwasyl commented Jul 19, 2019

In RSpec it's allowed to nest describe blocks. It's be nice to be able to nest describe blocks in DescribeSpec as well, but right now it's not possible. Is there any technical limitation to this or it's a deliberate decision?

I wanted to add a describe alias on DescribeScope, but the library describe is resolvable anyway and the tests fail in runtime

@LeoColman LeoColman added the enhancement ✨ Suggestions for adding new features or improving existing ones. label Jul 19, 2019
@LeoColman
Copy link
Member

This is a deliberate decision, however I don't see any reason to not allow this.

Currently you can use

describe -> context -> context -> ... -> it

No real issue to disallow
describe -> describe -> ...

I'll add this.

LeoColman added a commit that referenced this issue Jul 19, 2019
LeoColman added a commit that referenced this issue Jul 19, 2019
LeoColman added a commit that referenced this issue Jul 19, 2019
LeoColman added a commit that referenced this issue Jul 19, 2019
LeoColman added a commit that referenced this issue Jul 19, 2019
@sksamuel sksamuel mentioned this issue Jul 21, 2019
39 tasks
sksamuel pushed a commit that referenced this issue Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants