New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restored Robolectric extension build and refactored build.gradle.kts #1757
Restored Robolectric extension build and refactored build.gradle.kts #1757
Conversation
Still not running properly for some configuration/Gradle reasons. Needs investigation.
I would consider the work on moving the Robolectric extension and updating versions etc to the main repo done. I’ve tried to create an Android submodule in the tests module in order to have a proof that the extension works, but it is not passing giving me runtime errors regarding some internal Robolectric classes not found. Although, the extension seems to be perfectly working if I use an external project linked with the library produced by kotest, so I think it’s mostly a problem regarding the definitely weird nature of adding an android project as a sub-sub-module of a multiplatform project I was thinking that we might temporarily remove the android project from the repo so the test is not failing anymore, and we then could consider the PR mergeable |
|
||
import org.junit.runners.model.FrameworkMethod | ||
import org.robolectric.RobolectricTestRunner | ||
import org.robolectric.internal.bytecode.InstrumentationConfiguration | ||
|
||
class ContainedRobolectricRunner : RobolectricTestRunner(PlaceholderTest::class.java) { | ||
public class ContainedRobolectricRunner : RobolectricTestRunner(PlaceholderTest::class.java) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add public here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committed that by mistake, I'll remove
It seems the Robolectric extension was excluded from the project build. I've added it again and corrected some dependencies.