Performance improvements for Exceptions on the JVM #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For our usecase we have lots of exceptions being created by `shouldBe` and similar. We noticed that a lot of time was being spent in class loading. Since it is unlikely the availability of the JUnit 4/5 Assertion classes will change during runtime we can cache the class and constructor lookup. Our test suite now runs in 45 seconds instead of 85, which I would consider a worthwhile improvement.
|
Nice improvement. Will merge once green. |
sksamuel
pushed a commit
that referenced
this pull request
Oct 31, 2020
For our usecase we have lots of exceptions being created by `shouldBe` and similar. We noticed that a lot of time was being spent in class loading. Since it is unlikely the availability of the JUnit 4/5 Assertion classes will change during runtime we can cache the class and constructor lookup. Our test suite now runs in 45 seconds instead of 85, which I would consider a worthwhile improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our usecase we have lots of exceptions being created by
shouldBeand similar. We noticed that a lot of time was being spent in class loading. Since it is unlikely the availability of the JUnit 4/5 Assertion classes will change during runtime we can cache the class and constructor lookup.Our test suite now runs in 45 seconds instead of 85, which I would consider a worthwhile improvement.