Added inline version for intanceOf alias #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a version of `instanceOf` that is inlined with a reified generic type. This was done to remove the need for `::class` from the caller. This type of function is already implemented for `beInstanceOf` and `beOfType`. This commit just also adds it to `instanceOf`. Also updated the tests to test every matcher, even aliases. I don't suspect anyone would accidentally change the implementation of the aliased functions, but you never know.
|
Thanks. There's always |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a version of
instanceOfthat is inlined with a reified generictype. This was done to remove the need for
::classfrom the caller.This type of function is already implemented for
beInstanceOfandbeOfType. This commit just also adds it toinstanceOf.Also updated the tests to test every matcher, even aliases. I don't
suspect anyone would accidentally change the implementation of the
aliased functions, but you never know.
Fixes #1836