Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2312 Makes beforeAll and afterAll suspend functions #2333

Merged
merged 3 commits into from Jul 6, 2021
Merged

#2312 Makes beforeAll and afterAll suspend functions #2333

merged 3 commits into from Jul 6, 2021

Conversation

ashishkujoy
Copy link
Contributor

No description provided.

@sksamuel
Copy link
Member

sksamuel commented Jul 3, 2021

This is a breaking change. What about deprecating the old names, and adding beforeProject / afterProject as suspend equivalents ?

@ashishkujoy
Copy link
Contributor Author

This is a breaking change. What about deprecating the old names, and adding beforeProject / afterProject as suspend equivalents ?

Sure make sense.

sksamuel
sksamuel requested changes Jul 4, 2021
View reviewed changes
Copy link
Member

@sksamuel sksamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but we should still call both methods from the created config, otherwise people's listeners will silently start to fail in 5.0.

@ashishkujoy ashishkujoy merged commit 6d461d1 into master Jul 6, 2021
@ashishkujoy ashishkujoy deleted the before-after-all-suspended-version branch July 6, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sksamuel sksamuel sksamuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashishkujoy @sksamuel