Added gradle convention plugins #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kantis
commented
Jun 1, 2022
|
|
||
| kotlin { | ||
| targets { | ||
| js(BOTH) { |
There was a problem hiding this comment.
We sometimes used to target js(IR) and sometimes js(BOTH). Are we ready to go to IR only?
There was a problem hiding this comment.
I guess once 1.7 comes out we could ditch BOTH ?
Comment on lines
9
to
28
| linuxX64() | ||
|
|
||
| mingwX64() | ||
|
|
||
| macosX64() | ||
| macosArm64() | ||
|
|
||
| tvos() | ||
| tvosSimulatorArm64() | ||
|
|
||
| watchosArm32() | ||
| watchosArm64() | ||
| watchosX86() | ||
| watchosX64() | ||
| watchosSimulatorArm64() | ||
|
|
||
| iosX64() | ||
| iosArm64() | ||
| iosArm32() | ||
| iosSimulatorArm64() |
There was a problem hiding this comment.
TODO: Option to configure targets, all multiplatform targets should still be default.
There was a problem hiding this comment.
Having a hard time figuring this one out.. perhaps hard to solve with buildSrc plugins, might be more suited for a proper internal kotest gradle plugin..
Kantis
force-pushed
the
convention-plugins
branch
from
86ae7ca
to
05bc44d
Compare
sksamuel
approved these changes
Jun 2, 2022
charleskorn
added a commit
to charleskorn/kotest
that referenced
this pull request
Jul 22, 2022
This seems to have been accidentally removed in kotest#3024.
sksamuel
pushed a commit
that referenced
this pull request
Jul 24, 2022
This seems to have been accidentally removed in #3024.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.