Use the original failure when ErrorCollector contains single failure #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myuwono
approved these changes
Oct 31, 2022
myuwono
reviewed
Oct 31, 2022
| import io.kotest.matchers.should | ||
| import io.kotest.matchers.shouldBe | ||
|
|
||
| class ErrorCollectorTests : FreeSpec( |
There was a problem hiding this comment.
ah right there's no module for jsTest..
There was a problem hiding this comment.
Not sure what you meant with this 🤪 Did you mean that we should add a jsTest to check that I didn't break the js/desktop error collector?
matejdro
approved these changes
Nov 14, 2022
| actual fun ErrorCollector.collectiveError(): AssertionError? { | ||
| val failures = errors() | ||
| clear() | ||
| return if (failures.isNotEmpty()) { |
There was a problem hiding this comment.
Could this be written cleaner as a when or else if statement instead of nested if?
There was a problem hiding this comment.
It could, yeah.. I'll do that.
Kantis
force-pushed
the
issue-3236/return-original-assertion-failure
branch
from
ad8ae74
to
7806e5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3236
AssertionFailedErroris JVM-specific, so had to move some stuff to expect/actuals.