Adding support for partial permutations #3523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickeelm
force-pushed
the
partial_permutations
branch
from
d494d53
to
dee0f13
Compare
|
Converting to draft as partial permutations of length zero aren't correctly handled, needs to be fixed. |
mickeelm
force-pushed
the
partial_permutations
branch
from
51e61a4
to
41e97ed
Compare
|
@mickeelm this needs an updated apiDump :) |
mickeelm
force-pushed
the
partial_permutations
branch
2 times, most recently
from
a3d63b7
to
15cb353
Compare
Adding length parameter (defaults to list size) to the permutations function, providing the opportunity of creating exhaustives of partial permutations/k-permutations. Also, changed the assertion of the full permutations test from shouldBe to shouldContainExactlyInAnyOrder, as the order in which the permutations come are not (should not be) relevant. This also makes the test less dependent on the underlying implementation. The empty list check was removed, as an empty list will result in a list of an empty list (as with all permutations of length 0). This commit does break binary compatibility, due to adding the length parameter.
mickeelm
force-pushed
the
partial_permutations
branch
from
15cb353
to
e7610ef
Compare
sksamuel
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding length parameter (defaults to list size) to the permutations function, providing the opportunity of creating exhaustives of partial permutations/k-permutations.
Also, changed the assertion of the full permutations test from shouldBe to shouldContainExactlyInAnyOrder, as the order in which the permutations come are not (should not be) relevant. This also makes the test less dependent on the underlying implementation.
This PR does break binary compatibility, due to adding the length parameter.