Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RequiresTagInterceptor): Add fix to handle scenario where no tags are present in the runtime tags, but some specs are annotated with @RequiresTag() #3532

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

zakhenry
Copy link
Contributor

Fixes #3531

@Kantis
Copy link
Member

Kantis commented May 18, 2023

@zakhenry I would like to check when the behaviour of @RequiresTag regressed (assuming it did). The strategy of testing in b551ce1 relies on RequiresTagInterceptor which is newer than the original issue, so I can't cherry-pick the test into older versions to see when it started failing. If you don't mind, I propose an alternate strategy in 01ea26c which should be backportable.

Edit: Had to update api dump as well

@Kantis Kantis force-pushed the fix/requirestag-without-passing-tags branch from 1698b1e to 01ea26c Compare May 18, 2023 21:26
@zakhenry
Copy link
Contributor Author

Yea I guess that is fine for determining when this happened though the fact that you had to disable the test isn't ideal so it might be good to restore the explicit RequiresTagInterceptor tests as they cover the use case more directly by constructing the TagExpression

@Kantis Kantis force-pushed the fix/requirestag-without-passing-tags branch 2 times, most recently from c28c279 to 158e6f4 Compare May 18, 2023 22:44
@Kantis Kantis force-pushed the fix/requirestag-without-passing-tags branch from 158e6f4 to ca1b9a5 Compare May 19, 2023 05:47
@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale 🏚️ Issues that were lost to time and are no longer up-to-date label Jun 18, 2023
@zakhenry
Copy link
Contributor Author

Bump

@stale stale bot removed the stale 🏚️ Issues that were lost to time and are no longer up-to-date label Jun 18, 2023
@Kantis Kantis added this to the 5.7 milestone Jul 26, 2023
@Kantis Kantis merged commit 2d59bf4 into kotest:master Jul 26, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@RequiresTag does not work as expected
2 participants