Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Arb<Date> support #3554

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Add Arb<Date> support #3554

merged 1 commit into from
Jun 8, 2023

Conversation

vladeekkk
Copy link
Contributor

  1. added Arb for java.util.Date
  2. wrote test for it

@vladeekkk vladeekkk force-pushed the feature/arb_date branch 2 times, most recently from 85b3a54 to d72cf4a Compare June 3, 2023 22:09
@vladeekkk vladeekkk force-pushed the feature/arb_date branch 5 times, most recently from 093c898 to 1d8ef30 Compare June 5, 2023 07:37
@vladeekkk
Copy link
Contributor Author

Some checks failed because LocalDate.ofInstant() is only in Java 9 and later, so I used ZonedDateTime.ofInstant() instead in DateTest.kt.

@vladeekkk
Copy link
Contributor Author

#3503

@Kantis
Copy link
Member

Kantis commented Jun 8, 2023

Thank you for the contribution @vladeekkk 🙏🏼

@Kantis Kantis merged commit 71c1826 into kotest:master Jun 8, 2023
19 checks passed
@Kantis Kantis added this to the 5.7 milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kantis Kantis Kantis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vladeekkk @Kantis