Compiler plugin: fix IrLinkageError with K/Js on Kotlin 1.9 #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes kotest#3556 – IrLinkageError if objects or abstract subclasses of AbstractProjectConfig exist in K/Js sources This commit makes the Kotest compiler plugin skip non-instantiable classes and objects, which derive from AbstractProjectConfig. Note: To use objects deriving from AbstractProjectConfig on K/Js, they must be referenced at least once in code that executes, otherwise they will be discarded (with the IDE warning "object ... is never used)".
|
Hmm, wondering why the compiler plugin is part of the API check. There should probably be an exclusion defined in an @sksamuel Should I act upon this? If so, as part of this PR or a separate one, which would have to be merged first? |
|
Putting something like this in the top-level apiValidation {
ignoredPackages.addAll(
listOf(
"io.kotest.framework.multiplatform.embeddablecompiler",
"io.kotest.framework.multiplatform.gradle",
"io.kotest.framework.multiplatform.native"
)
)
} |
|
Seems reasonable to me. Those packages are gonna change a lot.
…On Sun, Jun 11, 2023, 8:51 AM OliverO2 ***@***.***> wrote:
Putting something like this in the top-level build.gradle.kts and then
running apiDump would work:
apiValidation {
ignoredPackages.addAll(
listOf(
"io.kotest.framework.multiplatform.embeddablecompiler",
"io.kotest.framework.multiplatform.gradle",
"io.kotest.framework.multiplatform.native"
)
)
}
—
Reply to this email directly, view it on GitHub
<#3557 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVSGQV5IREYR2LXW3RR4DXKXEOXANCNFSM6AAAAAAY6KOPSY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
sksamuel
approved these changes
Jun 16, 2023
|
Nice work :) |
|
Always a pleasure! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3556 – IrLinkageError if objects or abstract subclasses of AbstractProjectConfig exist in K/Js sources
This commit makes the Kotest compiler plugin skip non-instantiable classes and objects, which derive from AbstractProjectConfig.
Note: To use objects deriving from AbstractProjectConfig on K/Js, they must be referenced at least once in code that executes, otherwise they will be discarded (with the IDE warning "object ... is never used").