Fix Arb.list failing within edge cases in case of null values #3982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexCue987
reviewed
Apr 25, 2024
| @@ -91,6 +92,11 @@ class CollectionsTest : DescribeSpec({ | |||
| it.shouldHaveAtMostSize(500) | |||
| } | |||
| } | |||
|
|
|||
| it("not fail on edge cases for non-empty lists with null values") { | |||
There was a problem hiding this comment.
as the success here is "it doesn't throw an exception", should we say so: shouldNotThrowAny ...
also do we need to add any other checks for the output?
|
shouldNoThrowAny sounds great.
Don't think a check on the output adds any benefit though, but I'll give it
another thought.
…On Thu, Apr 25, 2024, 22:25 Alex Kuznetsov ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
kotest-property/src/jvmTest/kotlin/com/sksamuel/kotest/property/arbitrary/CollectionsTest.kt
<#3982 (comment)>:
> @@ -91,6 +92,11 @@ class CollectionsTest : DescribeSpec({
it.shouldHaveAtMostSize(500)
}
}
+
+ it("not fail on edge cases for non-empty lists with null values") {
as the success here is "it doesn't throw an exception", should we say so: shouldNotThrowAny
...
also do we need to add any other checks for the output?
—
Reply to this email directly, view it on GitHub
<#3982 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKAMQI3M45W7HC44R7G5K4TY7FRFJAVCNFSM6AAAAABGY4RSEGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRTGUYTAMRQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Updated: I've added some more scenarios and introduced some output checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shall fix the issue as described in #3981.
Instead of just assuming that a null value means "there is no edge case", this change adds explicitly checking that, effectively fixing the problem.