Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a leave button to Exit from meet 👋 #17

Closed
kothariji opened this issue Mar 6, 2021 · 16 comments · Fixed by #38
Closed

Add a leave button to Exit from meet 👋 #17

kothariji opened this issue Mar 6, 2021 · 16 comments · Fixed by #38
Assignees
Labels
fixed good first issue Good for newcomers GSSOC21 JS Level2 Bug fixing, adding small features. (level 2) Priority: High ux-improvement

Comments

@kothariji
Copy link
Owner

Description

Currently, there is no option to leave the meeting. So we just need a leave meet button(probably in deep red color) so that anyone can exit from the meet, and redirect to the home page.

@Devenkapoor7303
Copy link
Contributor

Can I work on this issue as a Part of GSSOC 21

@kothariji
Copy link
Owner Author

kothariji commented Mar 8, 2021

Can I work on this issue as a Part of GSSOC 21

Hi @Devenkapoor7303 , First of all, thank you so much for taking out the time to work on this issue.

Definitely, Please go forward to work on this issue. I am assigning this Issue to you 👍
Few Suggestions from my end:

  • button background color deep red.
  • leave button should be placed on the rightmost part of the navbar(after about us). It will look nice.
    image

And last but not least,
Keep Contributing 🙏🔥

@Devenkapoor7303
Copy link
Contributor

Okay I will start working on this issue from today onwards ☺️

@kothariji
Copy link
Owner Author

Sounds Great🔥

@sahildotexe
Copy link

Hey !! I am a participant of GSSOC'21 , can you assign this issue to me?

@akash-salvi
Copy link
Collaborator

Hey, @sahildotexe, thank you for showing interest 🚀

We appreciate🙏 your dedication and efforts towards our project, but according to our contributing guidelines, Issues are assigned on the First Come First Serve basis.

Anyways feel free to check out other unassigned issues, or create an Issue if you spot one🎯.

Thank you😊, and Sorry for the inconvenience caused 🙌

@Devenkapoor7303
Copy link
Contributor

@kothariji I have added a leave meeting button can u review it so that i can make a PR?

Capture

@kothariji
Copy link
Owner Author

@Devenkapoor7303 This looks really nice, but there is just a slight modification.

  • Can you please just add a start icon, similar to the other buttons like room id, chat box. For eg. you can add callend material UI icon
    image

  • Also can you please use this HexCode for the background color of the leave button - #fa1e0e

  • Also button text leave meeting is kind of verbose. So instead you can do with only Leave with icon.

@Devenkapoor7303
Copy link
Contributor

Okay I will make these changes in the project

@kothariji
Copy link
Owner Author

Okay I will make these changes in the project

Sure

@Devenkapoor7303
Copy link
Contributor

@kothariji I have made the changes and added a icon also with the color you have mentioned

Capture

@kothariji
Copy link
Owner Author

Hey @Devenkapoor7303, this looks tremendous.
Please open a PR, so that we can review the code 🙌

@Devenkapoor7303
Copy link
Contributor

Okay I will make a PR so that u can review

@kothariji kothariji linked a pull request Mar 10, 2021 that will close this issue
@kothariji
Copy link
Owner Author

Fixed 🚀
Thanks, @Devenkapoor7303 for the contribution 🙌

Keep Contributing 🔥

@Devenkapoor7303
Copy link
Contributor

@kothariji thanks for cooperative nature as u have guided me

@kothariji
Copy link
Owner Author

@kothariji thanks for cooperative nature as u have guided me

Thank you 😊 🙏

@akash-salvi akash-salvi added the Level2 Bug fixing, adding small features. (level 2) label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed good first issue Good for newcomers GSSOC21 JS Level2 Bug fixing, adding small features. (level 2) Priority: High ux-improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants