Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 [FEAT: ] Download code feature #112

Merged
merged 3 commits into from
Apr 12, 2021

Conversation

amaan-ahmad
Copy link
Contributor

The feature has been tested successfully for all the currently supported languages

This PR includes:

  • addition of a utility function that returns the extension name for a requested language code
  • feature to allow users to download the code conveniently.

Closes: #96

Screenshot

image

@vercel
Copy link

vercel bot commented Apr 10, 2021

@amaan-ahmad is attempting to deploy a commit to a Personal Account owned by @kothariji on Vercel.

@kothariji first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kothariji/syntaxmeets/G5dCnYhtpHeKT3ojQJJdJLA8x7X9
✅ Preview: https://syntaxmeets-git-fork-amaan-ahmad-downloadcode-kothariji.vercel.app

@kothariji kothariji added GSSOC21 Level2 Bug fixing, adding small features. (level 2) labels Apr 10, 2021
Copy link
Owner

@kothariji kothariji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amaan-ahmad thanks for the PR 🔥
Things are working great. 🙌 ⭐

The only thing for which I am concerned with is UI
image
The footer of syntax editor is too poky..All buttons are tightly filled, which is a symbol of Bad UI.
Can you suggest any alternatives for that.

Also any suggestions for the same - @Vishv07 @Priyankcoder @jainaayush01 @AmeyaJain-25 @AyushShri

@jainaayush01
Copy link
Contributor

jainaayush01 commented Apr 10, 2021

I think we can go with only icons and on hover we can describe that this options to upload, copy to clipboard, download.
And we can keep the run as it is

@amaan-ahmad
Copy link
Contributor Author

Yes, @kothariji I agree with what you said, the UI does seem too crowded at the bottom. also, I agree with @jainaayush01 opinion on it. We can remove the text and let alone icons sit there.

Another choice would be adding something like this image

to have an extended list of options available for users to choose from.

@AmeyaJain-25
Copy link
Contributor

Yes @kothariji ,
I think as @jainaayush01 said, that we can show the icons and on hovering we can give the description or title.
One more suggestion is that the enable auto-complete is taking a lot of space, which is not needed.
So, I think if we can shift of make it smaller which can give space at bottom and make it more clean.

Another way is to use a Modal/Dialog or PopUp to give options to Copy, Download, etc.

@kothariji
Copy link
Owner

kothariji commented Apr 11, 2021

Yes exactly, I feel the same @jainaayush01 @amaan-ahmad @AmeyaJain-25, actually, I think an Issue thread would be a much better place to talk on this 😄. So I have created issue #118 , and we all can discuss it there

@kothariji
Copy link
Owner

For now, @amaan-ahmad , can you please change thing accordingly

  1. remove Enable from Enable Auto-complete because its understandable, no need of enale keyword.
    image
  2. Can you please add Button Group of Maerial UI for upload and download code...with just symbols. No text.. Just two symbols in button group format
    will work. We will work on it in issue Simplify SyntaxEditor Footer 📂 🛠️ #118

image

We can merge this PR, once this points are validated

@Vishv07
Copy link
Contributor

Vishv07 commented Apr 11, 2021

I think as of now we can just put a download icon there no need to put the whole button than an icon into the button to make some space. or maybe just icons for all the three options except RUN.

@amaan-ahmad
Copy link
Contributor Author

Hey @kothariji
Yes I understood the changes that are to be made, my suggestion is let's do further discussion in issue #118 and merge this PR

@kothariji
Copy link
Owner

Hey @kothariji
Yes I understood the changes that are to be made, my suggestion is let's do further discussion in issue #118 and merge this PR

Sure @amaan-ahmad, but if I merge this PR now, it will move to production, and the syntaxeditor footer won't look good. So if possible can you please do 2 quick changes.
1 .remove Enable from Enable Auto-complete.
2. Please add Button Group of Material UI for upload and download code...with just symbols.

So that it will work for now. Because we are not sure how much time #118 will take to resolve Right ?.

@amaan-ahmad
Copy link
Contributor Author

Okay @kothariji

image

How about this?

Copy link
Owner

@kothariji kothariji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions 🔥

Keep contributing 🚀

@kothariji kothariji merged commit 57b5343 into kothariji:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSSOC21 Level2 Bug fixing, adding small features. (level 2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 [FEAT: ] Download code feature.
5 participants