Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing RoomId copied message #95

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Changing RoomId copied message #95

merged 1 commit into from
Mar 29, 2021

Conversation

Lavcodes
Copy link
Contributor

Solves #93

Changed message on copying RoomId to "Invite created ! Share with your friends and have a meet."

@vercel
Copy link

vercel bot commented Mar 25, 2021

@Lavcodes is attempting to deploy a commit to a Personal Account owned by @kothariji on Vercel.

@kothariji first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 25, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kothariji/syntaxmeets/37TcgbbELGtcBhSSgqn2thn1iSDA
✅ Preview: https://syntaxmeets-git-fork-lavcodes-roomidmessage-kothariji.vercel.app

kothariji
kothariji approved these changes Mar 27, 2021
View reviewed changes
Copy link
Owner

@kothariji kothariji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kothariji kothariji linked an issue Mar 27, 2021 that may be closed by this pull request
Bug with copying RoomId #93
Closed
@kothariji kothariji added good first issue Good for newcomers GSSOC21 Level1 Major Documentation, Minor Code Changes (level 1) and removed good first issue Good for newcomers labels Mar 27, 2021
@kothariji
Copy link
Owner

kothariji commented Mar 28, 2021 •
edited
Loading

@Lavcodes can you please resolve the merge conflicts, so that we can merge the PR. 🙌

@Lavcodes
Copy link
Contributor Author

I've tried resolving these conflicts could you review

@kothariji
Copy link
Owner

kothariji commented Mar 28, 2021 •
edited
Loading

I've tried resolving these conflicts could you review

@Lavcodes can you please uncommit the package-lock.json, because its preventing me from merging(reason - merge conflicts)

@Lavcodes
Copy link
Contributor Author

I've uncommitted those changes

kothariji
kothariji approved these changes Mar 29, 2021
View reviewed changes
Copy link
Owner

@kothariji kothariji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions @Lavcodes 🔥

Keep Contributing 🙌 🚀

@kothariji kothariji merged commit ba7f0e1 into kothariji:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kothariji kothariji kothariji approved these changes

Assignees
No one assigned
Labels
GSSOC21 Level1 Major Documentation, Minor Code Changes (level 1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with copying RoomId
2 participants
@Lavcodes @kothariji