Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing package in Long.kt file #14

Closed
SerVB opened this issue Jul 10, 2018 · 3 comments
Closed

Missing package in Long.kt file #14

SerVB opened this issue Jul 10, 2018 · 3 comments

Comments

@SerVB
Copy link
Contributor

SerVB commented Jul 10, 2018

Hello!

There is no package unsigned here: https://github.com/kotlin-graphics/kotlin-unsigned/blob/master/src/main/kotlin/unsigned/Long.kt.

Is it made on purpose or is it a bug? ;)

@elect86
Copy link
Collaborator

elect86 commented Jul 10, 2018

Definitely a bug, thanks

@SerVB
Copy link
Contributor Author

SerVB commented Jul 10, 2018

You are welcome. Actually, your commit is not enough. There are many imports from default package (for example, in tests). Now the project doesn't compile and tests don't pass.

Could you check my commit out?

https://github.com/SerVB/kotlin-unsigned/commit/2827d744ba3f783a5559df6f27d595fe559d15c4

I can make a PR if you like.

@elect86
Copy link
Collaborator

elect86 commented Jul 10, 2018

I'm not at dev pc now, your pr is very very welcome

elect86 added a commit that referenced this issue Jul 10, 2018
Remove imports from default package (#14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants