Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add matchers to Klock #1156

Closed
LeoColman opened this issue Jan 14, 2020 · 2 comments
Closed

Add matchers to Klock #1156

LeoColman opened this issue Jan 14, 2020 · 2 comments
Labels
assertions 🔍 Related to the assertion mechanisms within the testing framework. enhancement ✨ Suggestions for adding new features or improving existing ones. good-first-issue 👶 Suitable for newcomers looking to contribute to the project.
Milestone
4.0

Comments

@LeoColman
Copy link
Member

Klock is an MPP Kotlin Library to handle Date and Time in a MPP fashion.

We should add some matchers to their types, similar to the ones we have for java.time
@LeoColman LeoColman added enhancement ✨ Suggestions for adding new features or improving existing ones. good-first-issue 👶 Suitable for newcomers looking to contribute to the project. assertions 🔍 Related to the assertion mechanisms within the testing framework. labels Jan 14, 2020
@sksamuel sksamuel added this to the 4.1 milestone Jan 14, 2020
@dragneelfps
Copy link
Contributor

dragneelfps commented Feb 11, 2020 •
edited

@Kerooker I would like to work on this. So for starters, we would need to create a separate module kotest-assertions-kclock, right?

@dragneelfps dragneelfps mentioned this issue Feb 11, 2020
Merged
@LeoColman
Copy link
Member Author

Closed as per #1214

@sksamuel sksamuel modified the milestones: 4.1, 4.0 Mar 24, 2020
@sksamuel sksamuel mentioned this issue Mar 24, 2020
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assertions 🔍 Related to the assertion mechanisms within the testing framework. enhancement ✨ Suggestions for adding new features or improving existing ones. good-first-issue 👶 Suitable for newcomers looking to contribute to the project.
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
3 participants
@sksamuel @LeoColman @dragneelfps