Add suspend alternative to Data Driven Testing #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit creates a suspended alternative for the data driven testing methods. It also inlines all possible functions in TableTesting. The same approach was not used for the data driven due to the fact that we're using reflect on the functions to obtain the parameter name, and that makes inlining impossible. To avoid too many maintenance points, I decided to refactor the functions a little bit, so that the execution could be used both in the normal version and the suspended version, shortening the code a little bit. However, I couldn't find any alternatives for the tests, so I duplicated every test that tested the data driven functions to use the suspended overload. An important note on this is that the function name is not `forallSuspendOverload`, it's just how I imported it. Fixes #707
sksamuel
approved these changes
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit creates a suspended alternative for the data driven testing methods. It also inlines all possible functions in TableTesting. The same approach was not used for the data driven due to the fact that we're using reflect on the functions to obtain the parameter name, and that makes inlining impossible.
To avoid too many maintenance points, I decided to refactor the functions a little bit, so that the execution could be used both in the normal version and the suspended version, shortening the code a little bit.
However, I couldn't find any alternatives for the tests, so I duplicated every test that tested the data driven functions to use the suspended overload. An important note on this is that the function name is not
forallSuspendOverload, it's just how I imported it.Fixes #707