Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow key movement broken in the REPL on Windows #130

Closed
irh opened this issue Dec 10, 2021 · 0 comments · Fixed by #155
Closed

Arrow key movement broken in the REPL on Windows #130

irh opened this issue Dec 10, 2021 · 0 comments · Fixed by #155
Labels
bug Something isn't working good first issue Good for newcomers repl Issues related to Koto's repl

Comments

@irh
Copy link
Contributor

irh commented Dec 10, 2021

When using the REPL on Windows, left and right arrow key movement is broken, with movements moving to unexpected positions, eventually leading to a panic.
@irh irh added bug Something isn't working good first issue Good for newcomers repl Issues related to Koto's repl labels Dec 10, 2021
irh added a commit that referenced this issue Apr 5, 2022
@irh
Move the REPL cursor using a calculated x position instead of moving …
c3a6a85 
…relatively

Fixes #130 - relative movement was relying on the cursor position to be correct,
which isn't the case on Windows before flushing the output.
irh added a commit that referenced this issue Apr 5, 2022
@irh
Move the REPL cursor using a calculated x position instead of moving …
6f02ace 
…relatively

Fixes #130 - relative movement was relying on the cursor position to be correct,
which isn't the case on Windows before flushing the output.
@irh irh mentioned this issue Apr 5, 2022
Merged
irh added a commit that referenced this issue Apr 5, 2022
@irh
Move the REPL cursor using a calculated x position instead of moving …
ddaf478 
…relatively

Fixes #130 - relative movement was relying on the cursor position to be correct,
which isn't the case on Windows before flushing the output.
@irh irh closed this as completed in #155 Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers repl Issues related to Koto's repl
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REPL improvements koto-lang/koto
1 participant
@irh