Skip to content

Commit

Permalink
Swap log with cbrt for commit bar height (facebook#20952)
Browse files Browse the repository at this point in the history
  • Loading branch information
Brian Vaughn authored and koto committed Jun 15, 2021
1 parent 4f0ddf8 commit 75d53ac
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,18 +40,18 @@ function SnapshotCommitListItem({data: itemData, index, style}: Props) {
const commitDuration = commitDurations[index];
const commitTime = commitTimes[index];

// Use natural log for bar height.
// Use natural cbrt for bar height.
// This prevents one (or a few) outliers from squishing the majority of other commits.
// So rather than e.g. _█_ we get something more like e.g. ▄█_
const heightScale =
Math.min(
1,
Math.max(0, Math.log(commitDuration) / Math.log(maxDuration)),
Math.max(0, Math.cbrt(commitDuration) / Math.cbrt(maxDuration)),
) || 0;

// Use a linear scale for color.
// This gives some visual contrast between cheaper and more expensive commits
// and somewhat compensates for the log scale height.
// and somewhat compensates for the cbrt scale height.
const colorScale =
Math.min(1, Math.max(0, commitDuration / maxDuration)) || 0;

Expand Down

0 comments on commit 75d53ac

Please sign in to comment.