Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”₯ Removal of kotools.types.web.EmailAddress type #639

Open
2 tasks
LVMVRQUXL opened this issue Apr 4, 2024 · 6 comments
Open
2 tasks

πŸ”₯ Removal of kotools.types.web.EmailAddress type #639

LVMVRQUXL opened this issue Apr 4, 2024 · 6 comments
Labels
common Item related to all platforms. feature New feature or request. good first issue Issues having enough details for new contributors to work on.
Milestone

Comments

@LVMVRQUXL
Copy link
Contributor

LVMVRQUXL commented Apr 4, 2024

πŸ“ Description

After deprecating it in #635, we want to remove the EmailAddress type from the kotools.types.web package.

βœ… Checklist

@LVMVRQUXL LVMVRQUXL added feature New feature or request. common Item related to all platforms. labels Apr 4, 2024
@LVMVRQUXL LVMVRQUXL added this to the 4.7.0 milestone Apr 4, 2024
@LVMVRQUXL LVMVRQUXL modified the milestones: 4.6.0, 4.5.2 Apr 28, 2024
@LVMVRQUXL LVMVRQUXL added the good first issue Issues having enough details for new contributors to work on. label Apr 29, 2024
@LVMVRQUXL LVMVRQUXL self-assigned this May 16, 2024
@LVMVRQUXL LVMVRQUXL added good first issue Issues having enough details for new contributors to work on. and removed good first issue Issues having enough details for new contributors to work on. labels May 16, 2024
@LVMVRQUXL LVMVRQUXL removed their assignment May 16, 2024
@LVMVRQUXL LVMVRQUXL modified the milestones: 4.5.2, 4.6.0 May 17, 2024
@MartiPresa
Copy link

Hi, can i work on this issue? Thanks

@LVMVRQUXL
Copy link
Contributor Author

Hello @MartiPresa, sure!
Check our contributing guidelines for tackling this issue, and feel free to ask for help here or in discussions if needed.
Thank you for considering to contribute. πŸ™

@MartiPresa
Copy link

Hi, should i keep the index and only the index from kotools.types.web? Thanks, and sorry for the inconvenience.

@LVMVRQUXL
Copy link
Contributor Author

Hello @MartiPresa, what do you mean about "the index and only the index from kotools.types.web"?

@MartiPresa
Copy link

I mean do i have to remove the entire -email-address file from kotools.types.web?

@LVMVRQUXL
Copy link
Contributor Author

No @MartiPresa, only remove the source file implementing the EmailAddress type from the kotools.types.web package and its tests. This issue is not related to documentation but source declaration (that's why this issue doesn't have the documentation label). Documentation will be updated automatically after implementing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Item related to all platforms. feature New feature or request. good first issue Issues having enough details for new contributors to work on.
Projects
None yet
Development

No branches or pull requests

2 participants