Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task 14+ #2

Open
wants to merge 114 commits into
base: master
Choose a base branch
from
Open

Task 14+ #2

wants to merge 114 commits into from

Conversation

val-fom
Copy link
Collaborator

@val-fom val-fom commented Apr 18, 2018

Hi! Please review!

Thank you!

@val-fom
add .editorconfig file
6c8bd9b
@val-fom
update webpack.config.js
32d0492
@val-fom
update package.json
a5c4c62
@val-fom
refactor to employ components
ba60d4f
@val-fom
move @media into components style
1181050
@val-fom
add Clock component
2b1811e
@val-fom
add insertChildren util
82ff83c
@val-fom
add basic router
6782e67
@val-fom
update the links
02328d9
@val-fom
add classNames for hosts for App and Login
5658025
@val-fom
login-form styling
2a31acd
@val-fom
add Register component
5f3e51b
@val-fom
add README
6efd2c3
@val-fom
npm update
363cdee
@val-fom
update README
9ceb947
@val-fom
change labels color
842e4f8
@val-fom
add handleRedirect and handleOnEnter
a59ad1e
@val-fom
add Choose your store select in Register form
e5b6c87
@val-fom
fix Error message
bb70eda
@val-fom
add store password
2d55e1b
@val-fom
add basic login and registration services
f2a89b4
@val-fom
fix clock
d39cefa
@val-fom
fix Component.update
e649583
@val-fom
add Message component
ae55577
@val-fom
point Vals store as a default option
8844eaf
@val-fom
add Message component to RegisterForm
7eb001b
@val-fom
LoginForm and RegisterForm small refactor
2c83dc2
@val-fom
fix: prevent form reload. Update only the message
a97f5bc
@val-fom
try to make auth http request
b5cca33
@val-fom
receive user_info
5c25ecf
@turchak
Copy link

turchak commented Apr 24, 2018

When I go to add pizza page first time loaded I can see pizza price 0.00, but when I change pizza size or choose ingredients and discard this, I cannot again see that 0.00 price.

@val-fom
Copy link
Collaborator Author

val-fom commented Apr 25, 2018

@turchak, do you mean that I should never show a price of $0.00? i.e. $12.00 for 60 cm pizza as it is checked by default

@turchak
Copy link

turchak commented Apr 25, 2018

I think it depends on your business logic, but you have to choose one variant 😄

@val-fom
Copy link
Collaborator Author

val-fom commented Apr 25, 2018

@turchak ok, thx 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mentors review wanted peer review wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@val-fom @turchak