Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiny js world #55

Merged
merged 2 commits into from
Mar 22, 2019
Merged

tiny js world #55

merged 2 commits into from
Mar 22, 2019

Conversation

madmaxWMFU
Copy link
Contributor

Building a Tiny JS World

Demo |
Code base

The code is submitted in its own sub-directory and in a dedicated feature branch.
Please, review.

@o-msh o-msh self-assigned this Mar 22, 2019
@o-msh o-msh added the task-TJSW Task: Building a Tiny JS World label Mar 22, 2019
Copy link
Member

@o-msh o-msh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madmaxWMFU Thank for you submission! Minor changes and i'll merge it.

submissions/madmaxWMFU/a-tiny-JS-world/index.js Outdated Show resolved Hide resolved
@o-msh
Copy link
Member

o-msh commented Mar 22, 2019

@madmaxWMFU LGTM!
You next task is about OOP. Then you will be back to your tiny JS world and will be required to refactor your code to follow OOP, SOLID, and DRY principles. Good luck!

@o-msh o-msh merged commit ac5efce into kottans:master Mar 22, 2019
dafen173 pushed a commit to dafen173/frontend-2019-p2p that referenced this pull request Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task-TJSW Task: Building a Tiny JS World
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants