Revert "fix(serverless-component): when adding primary domain name to…

… CloudFront distribution aliases, don't replace other aliases (serverless-nextjs#658)" This reverts commit 4428d5c.
kouhei-fuji · Oct 18, 2020 · 298acef · 298acef
1 parent 899baa6
commit 298acef
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/packages/serverless-components/domain/utils.js b/packages/serverless-components/domain/utils.js
@@ -392,19 +392,21 @@ const addDomainToCloudfrontDistribution = async (
   params.Id = subdomain.distributionId;
 
   // 5. then make our changes
-  params.DistributionConfig.Aliases.Items.push(subdomain.domain);
-  params.DistributionConfig.Aliases.Quantity += 1;
+  params.DistributionConfig.Aliases = {
+    Quantity: 1,
+    Items: [subdomain.domain]
+  };
+
   if (subdomain.domain.startsWith("www.")) {
     if (domainType === "apex") {
-      params.DistributionConfig.Aliases.Items[-1] = `${subdomain.domain.replace(
-        "www.",
-        ""
-      )}`;
+      params.DistributionConfig.Aliases.Items = [
+        `${subdomain.domain.replace("www.", "")}`
+      ];
     } else if (domainType !== "www") {
+      params.DistributionConfig.Aliases.Quantity = 2;
       params.DistributionConfig.Aliases.Items.push(
         `${subdomain.domain.replace("www.", "")}`
       );
-      params.DistributionConfig.Aliases.Quantity += 1;
     }
   }