Corrected test and multipart size check #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kouk
added a commit
that referenced
this pull request
Nov 14, 2013
Corrected test and multipart size check
|
thanks @attili ! |
|
My pleasure. |
|
it is now. I had to merge with some recent refactoring by @spulec but now we are synced and all tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_multipart_upload was failing because the .should.throw methods expects a function to call that will raise the exception. Just removing the ()'s passes the complete_upload() function rather than calling it directly.
Also, the size check on multipart uploads does not apply to the total file size, but applies to each individual part except for the last part.
Hopefully this can now be merged in to 'spulec's repository.