Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dismiss function and wrapped notification with Dismissible widget #109

Merged
merged 6 commits into from
Mar 10, 2024
Merged

Added dismiss function and wrapped notification with Dismissible widget #109

merged 6 commits into from
Mar 10, 2024

Conversation

Pana-g
Copy link
Contributor

@Pana-g Pana-g commented Feb 21, 2024

Dismiss function is called when closing the notification to remove it smoothly calling the reverse animation action. Dismissible Widget wrapped the ElegantNotification widget to allow swipe to dismiss action as per #107

@koukibadr
Copy link
Owner

@Pana-g you have conflict with the main branch otherwise the new updates may be similar to the updates already merged of this PR

@Pana-g
Copy link
Contributor Author

Pana-g commented Mar 4, 2024

@koukibadr The conflict has been resolved!

koukibadr
koukibadr approved these changes Mar 10, 2024
View reviewed changes
Copy link
Owner

@koukibadr koukibadr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @Pana-g

@koukibadr koukibadr merged commit 7075150 into koukibadr:main Mar 10, 2024
@koukibadr koukibadr mentioned this pull request Mar 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koukibadr koukibadr koukibadr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pana-g @koukibadr