homekit: handle mp4 generation shutdown

koush · Apr 15, 2024 · 69fd86a · 69fd86a
1 parent f0e85f1
commit 69fd86a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/plugins/homekit/package-lock.json b/plugins/homekit/package-lock.json
diff --git a/plugins/homekit/package.json b/plugins/homekit/package.json
@@ -1,6 +1,6 @@
 {
    "name": "@scrypted/homekit",
-   "version": "1.2.49",
+   "version": "1.2.50",
    "description": "HomeKit Plugin for Scrypted",
    "scripts": {
       "scrypted-setup-project": "scrypted-setup-project",

diff --git a/plugins/homekit/src/types/camera.ts b/plugins/homekit/src/types/camera.ts
@@ -103,7 +103,7 @@ addSupportedType({
         const isRecordingEnabled = device.interfaces.includes(ScryptedInterface.MotionSensor);
 
         let configuration: CameraRecordingConfiguration;
-        const openRecordingStreams = new Set<number>();
+        const openRecordingStreams = new Map<number, AsyncGenerator<RecordingPacket>>();
         if (isRecordingEnabled) {
             recordingDelegate = {
                 updateRecordingConfiguration(newConfiguration: CameraRecordingConfiguration) {
@@ -112,10 +112,12 @@ addSupportedType({
                 handleRecordingStreamRequest(streamId: number): AsyncGenerator<RecordingPacket> {
                     const ret = handleFragmentsRequests(streamId, device, configuration, console, homekitPlugin, 
                         () => openRecordingStreams.has(streamId));
-                    openRecordingStreams.add(streamId);
+                    openRecordingStreams.set(streamId, ret);
                     return ret;
                 },
                 closeRecordingStream(streamId, reason) {
+                    const r = openRecordingStreams.get(streamId);
+                    r?.throw(new Error(reason?.toString()));
                     openRecordingStreams.delete(streamId);
                 },
                 updateRecordingActive(active) {