Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TypeScript strict for packages/auth-fetch #1493

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Enable TypeScript strict for packages/auth-fetch #1493

merged 5 commits into from
Jun 4, 2024

Conversation

longzheng
Copy link
Contributor

Adding tsconfig.json strict: true to packages/auth-fetch

I had to tweak the types of server/src/fetch/index.ts and server/src/fetch/http-fetch.ts since packages/auth-fetch/src/auth-fetch.ts was calling functions with undefined values.

@longzheng longzheng changed the title Enable TypeScript script for packages/auth-fetch Enable TypeScript strict for packages/auth-fetch Jun 3, 2024
@koush koush merged commit cf1c500 into koush:main Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koush koush koush left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@longzheng @koush