Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build from a virtual workspace in Rust 1.40.0 #227

Open
AlephAlpha opened this issue Dec 24, 2019 · 4 comments
Open

Cannot build from a virtual workspace in Rust 1.40.0 #227

AlephAlpha opened this issue Dec 24, 2019 · 4 comments

Comments

@AlephAlpha
Copy link

AlephAlpha commented Dec 24, 2019

After updating to Rust 1.40, I can no longer run cargo web build -p package in a virtual workspace. it says that:

error: error: --features is not allowed in the root of a virtual workspace

I found this line in the Chagelog of Cargo 1.40:

--features and --no-default-features in the root of a virtual workspace will now generate an error instead of being ignored. rust-lang/cargo#7507

@nic-hartley
Copy link

I'm encountering this as well.

@nico-abram
Copy link

I'm also running into this. I tried adding the verbose flag but it change nothing.

@palfrey
Copy link

palfrey commented Feb 13, 2020

This is currently breaking the virtual_manifest test

Arvamer-mirror pushed a commit to Arvamer/gilrs that referenced this issue May 12, 2020
It's broken koute/cargo-web#227

It doesn't work
Arvamer-mirror pushed a commit to Arvamer/gilrs that referenced this issue May 12, 2020
It's broken koute/cargo-web#227

It doesn't work
@ThibaultLemaire
Copy link

My workaround up till now was to override rust version to 1.39.0 which is the latest working version.

Except within the last month remove_dir_all was updated to v0.5.3 and now uses cfg(doctest) which is apparently experimental in rust 1.39.0, so cargo-web doesn't even build on 1.39.0 anymore. (I don't know where in the dependency tree remove_dir_all comes from, but since cargo-web doesn't freeze versions for it's dependencies, it's always the latest version that will be used.)

The only way to get it to work is to first cargo install cargo-web with the latest rust, and only then rustup override set 1.39.0 and build your project.

Link to my working CI script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants