New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onFinished function's timing on texture loading #100
Comments
It works like this by design, so you can work with the model while textures are loading in the background. I think it's possible to wait for all textures to load before showing a model, but currently I don't plan to implement this behavior. |
This behaviour is okay, in practice though our testing model freezes entirely and the view cannot be moved until almost all textures are loaded, so therefore I would need some sort of function to at least display some indicator, till everything is loaded and usable. |
An example file set would help a lot to reproduce the issue. |
Hey, are you able to reproduce with this example ? https://mega.nz/file/QAsAUBLa#nG53MUU1VnT8cloYV0aZF2ufvAhIM-8R_eGDT7E-AbQ |
Yes, I can reproduce the issue now. There are a few things that you can do to prevent lagging:
Maybe it's possible to remove this power of two resizing from the viewer, but I have to investigate if it breaks anything. |
Created an issue (#105) for the investigation. |
With the fix of #105 the performance is much better, but it can be further optimized by decreasing the size of the textures. |
thank you ! Yes, we have a lot of optimisation happening in the backend of course, but unfortunately that kind of stuff is what out target audience is coming around with in the first place, so we need to deal with that unfortunately. |
hey, I'm still experiencing quite some heavy loading time on the repro in the latest release, am I doing something wrong or is this the best optimisation possible for now ? (no bad blood, just checking 😜 ) could this theoretically be improved somehow in the future? with additional help of someone or something ? |
One way is to lower the size of the textures. Another way could be to show progress dialog while all textures are loaded (this needs some programming, of course). |
By lowering the texture size you mean doing it on the creator's side, right ? This is something those poor guys and girls can't do with their programs yet... A load indicator would greatly help improving the user experience, people with high quality exports can't tell whether it's not their browser that simply froze ;) Will you be available for some reasoning about access to state and event functions some time later or so? |
I've created this issue to handle the situation: |
Hey, on obj files with lots of huge textures, the "loading" dialog disappears before all the textures are loaded entirely. (I'm asking for a public file I can hand you for repro right now). What essentially happens right now is that the 3d model almost freezes until all textures are loaded, which takes a while on my macbook pro late 2017. Here is a screenshot of the files, just as a hint for now:
The text was updated successfully, but these errors were encountered: